-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ceskatelevize] Update to 2021-12-06 changes (#1899) #1904
[ceskatelevize] Update to 2021-12-06 changes (#1899) #1904
Conversation
After a site redesign on 2021-12-06, player iframe is no longer present in the page from the start and is only inserted after pressing the "play" button. We need to query /v-api/iframe-hash/ to get hash to pass to iFramePlayer.php and extract "IDEC" id from a json in the original page.
5aacb4c
to
78a22f6
Compare
- use _search_nextjs_data() helper - use traverse_obj() nested syntax - better name for variable with iframe hash - do not use variables for URLs used only once
78a22f6
to
5417908
Compare
With 2021-12-20 master, extractor test 0 fails ( There has been another commit after this PR but it shouldn't have caused those failures. |
Seems to work here. Any chance you are hitting #2043? |
Satisfyingly, or not, I have a similar result (test 0) with my back-port to yt-dl, which led me to check the tests in yt-dlp. In the browser with JS disabled, |
After a site redesign on 2021-12-06, player iframe is no longer present in
the page from the start and is only inserted after pressing the "play"
button. We need to query /v-api/iframe-hash/ to get hash to pass to
iFramePlayer.php and extract "IDEC" id from a json in the original page.
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Fix downloading from www.ceskatelevize.cz after website redesign of 2012-06-12.