[extractor/common] introduce _search_nuxt_data
#1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jul 18, 2023
* add _search_nextjs_data(), from yt-dlp/yt-dlp#1386 thanks selfisekai * add _search_nuxt_data(), from yt-dlp/yt-dlp#1921, thanks Lesmiscore, pukkandan * add tests for the above * also fix HTML5 type recognition and tests, from yt-dlp/yt-dlp@222a230, thanks Lesmiscore * update extractors in PR using above, fix tests.
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jul 19, 2023
* add _search_nextjs_data(), from yt-dlp/yt-dlp#1386 thanks selfisekai * add _search_nuxt_data(), from yt-dlp/yt-dlp#1921, thanks Lesmiscore, pukkandan * add tests for the above * also fix HTML5 type recognition and tests, from yt-dlp/yt-dlp@222a230, thanks Lesmiscore * update extractors in PR using above, fix tests.
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jul 19, 2023
* add _search_nextjs_data(), from yt-dlp/yt-dlp#1386 thanks selfisekai * add _search_nuxt_data(), from yt-dlp/yt-dlp#1921, thanks Lesmiscore, pukkandan * add tests for the above * also fix HTML5 type recognition and tests, from yt-dlp/yt-dlp@222a230, thanks Lesmiscore * update extractors in PR using above, fix tests.
11 tasks
dirkf
added a commit
to dirkf/youtube-dl
that referenced
this pull request
Jul 19, 2023
* add _search_nextjs_data(), from yt-dlp/yt-dlp#1386 thanks selfisekai * add _search_nuxt_data(), from yt-dlp/yt-dlp#1921, thanks Lesmiscore, pukkandan * add tests for the above * also fix HTML5 type recognition and tests, from yt-dlp/yt-dlp@222a230, thanks Lesmiscore * update extractors in PR using above, fix tests.
dirkf
added a commit
to ytdl-org/youtube-dl
that referenced
this pull request
Jul 19, 2023
* add _search_nextjs_data(), from yt-dlp/yt-dlp#1386 thanks selfisekai * add _search_nuxt_data(), from yt-dlp/yt-dlp#1921, thanks Lesmiscore, pukkandan * add tests for the above * also fix HTML5 type recognition and tests, from yt-dlp/yt-dlp@222a230, thanks Lesmiscore * update extractors in PR using above, fix tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check one of the following options:
yt_dlp/extractor/sovietscloset.pyis licensed under Unlicense.What is the purpose of your pull request?
Description of your pull request and other information
Moves
parse_nuxt_jsonpout fromsovietscloset.pyas a convenient function.