Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[soundcloud] fix downloads #696

Closed
wants to merge 1 commit into from
Closed

Conversation

mkg20001
Copy link

@mkg20001 mkg20001 commented Aug 14, 2021

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This pull request fixes the soundcloud extractor

Changes:

  • app_version is now extracted aswell and stored, thought it would be necesarry but worked without - might be useful later
  • normal downloads with resolv_url() are now using hydration system (json data in soundcloud HTML that would have to be fetched over API otherwise)
  • client_id was updated to the latest

@mkg20001 mkg20001 mentioned this pull request Aug 14, 2021
5 tasks
@pukkandan
Copy link
Member

pukkandan commented Aug 14, 2021

b714b41 is sufficient to fix #673. Please explain and provide example where _get_hydratable is needed

@pukkandan
Copy link
Member

Closed due to inactivity

@pukkandan pukkandan closed this Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants