-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add erocast extractor. #8264
Add erocast extractor. #8264
Conversation
Thanks, updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. In the future, please avoid force pushing; it makes reviewing more difficult for us, and all commits will be squashed before merge anyways
Ah sorry, will keep that in mind for next time. Thanks for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally some of the whitespace should be condensed
Co-authored-by: Simon Sawicki <accounts@grub4k.xyz>
Closes yt-dlp#4001 Authored by: madewokherd
IMPORTANT: PRs without the template will be CLOSED
Description of your pull request and other information
Adds an extractor for erocast.me.
Fixes #4001
Template
Before submitting a pull request make sure you have:
In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:
What is the purpose of your pull request?
Copilot Summary
🤖 Generated by Copilot at b13703f
Summary
📦🚚🎨
Add support for erocast.com videos by importing a new extractor class
ErocastIE
fromerocast.py
.Walkthrough