Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add erocast extractor. #8264

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Add erocast extractor. #8264

merged 3 commits into from
Oct 6, 2023

Conversation

madewokherd
Copy link
Contributor

@madewokherd madewokherd commented Oct 2, 2023

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

Adds an extractor for erocast.me.

Fixes #4001

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

Copilot Summary

🤖 Generated by Copilot at b13703f

Summary

📦🚚🎨

Add support for erocast.com videos by importing a new extractor class ErocastIE from erocast.py.

Walkthrough

yt_dlp/extractor/erocast.py Outdated Show resolved Hide resolved
yt_dlp/extractor/erocast.py Outdated Show resolved Hide resolved
yt_dlp/extractor/erocast.py Outdated Show resolved Hide resolved
yt_dlp/extractor/erocast.py Outdated Show resolved Hide resolved
yt_dlp/extractor/erocast.py Outdated Show resolved Hide resolved
@bashonly bashonly added the pending-fixes PR has had changes requested label Oct 3, 2023
@madewokherd
Copy link
Contributor Author

Thanks, updated.

Copy link
Member

@bashonly bashonly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. In the future, please avoid force pushing; it makes reviewing more difficult for us, and all commits will be squashed before merge anyways

@bashonly bashonly added pending-review PR needs a review and removed pending-fixes PR has had changes requested labels Oct 5, 2023
@madewokherd
Copy link
Contributor Author

Ah sorry, will keep that in mind for next time. Thanks for the review.

Copy link
Member

@Grub4K Grub4K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally some of the whitespace should be condensed

yt_dlp/extractor/erocast.py Outdated Show resolved Hide resolved
Co-authored-by: Simon Sawicki <accounts@grub4k.xyz>
yt_dlp/extractor/erocast.py Outdated Show resolved Hide resolved
@bashonly bashonly requested a review from Grub4K October 5, 2023 23:05
@Grub4K Grub4K removed the pending-review PR needs a review label Oct 5, 2023
@bashonly bashonly merged commit 47c5987 into yt-dlp:master Oct 6, 2023
16 checks passed
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NSFW site-request Request to support a new website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NSFW] erocast.me
3 participants