Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ie/abematv] Fix season extraction #8607

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

middlingphys
Copy link
Contributor

IMPORTANT: PRs without the template will be CLOSED

Description of your pull request and other information

  1. Set season_number instead of series_number
  2. Fix key name for extracting season from api response

It looks like season_number is appropriate here, as

  • series_number is not listed in OUTPUT TEMPLATE, and

  • api response from abematv suggests season has number while series does not:

    "series":{"id":"194-25","title":"異世界食堂2", ...
    "season":{"id":"194-25_s2","sequence":2,"name":"シーズン2", ...

I wonder if series_number should be left for backward compatibility. Just remove the line if it is not necessary.

Template

Before submitting a pull request make sure you have:

In order to be accepted and merged into yt-dlp each piece of code must be in public domain or released under Unlicense. Check all of the following options that apply:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

yt_dlp/extractor/abematv.py Outdated Show resolved Hide resolved
@bashonly bashonly added the site-bug Issue with a specific website label Nov 18, 2023
Co-authored-by: bashonly <88596187+bashonly@users.noreply.github.com>
@bashonly bashonly self-assigned this Nov 20, 2023
@bashonly bashonly merged commit cc07f5c into yt-dlp:master Nov 20, 2023
aalsuwaidi pushed a commit to aalsuwaidi/yt-dlp that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site-bug Issue with a specific website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants