Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhasePlots don't correctly render ion fields for z_axis label #3269

Closed
chummels opened this issue May 16, 2021 · 2 comments · Fixed by #3425
Closed

PhasePlots don't correctly render ion fields for z_axis label #3269

chummels opened this issue May 16, 2021 · 2 comments · Fixed by #3425
Assignees
@chummels
Labels
bug viz: 2D

Comments

@chummels
Copy link
Member

chummels commented May 16, 2021 •
edited
Loading

Bug report

Bug summary

Usage of ion fields such as H_p0_mass (for H I mass) are not rendered properly for PhasePlot z-axis labels, but they work correctly for ProjectionPlots z-axis labels. I'm happy to fix this, but I cannot find where in the code ProjectionPlot is doing this step. Suggestions are welcome.

Code for reproduction

import yt
ds = yt.load_sample('IsolatedGalaxy')
yt.PhasePlot(ds, ('gas', 'density'), ('gas', 'temperature'), ('gas', 'H_p0_mass')).save()
yt.ProjectionPlot(ds, 'x', ('gas', 'H_p0_number_density')).save()

Actual outcome

galaxy0030_2d-Profile_density_temperature_H_p0_mass

galaxy0030_Projection_x_H_p0_number_density
@chummels chummels changed the title PhasePlots don't correctly render ion fields for z_axis PhasePlots don't correctly render ion fields for z_axis label May 16, 2021
@chummels chummels added the bug label May 16, 2021
@chummels chummels mentioned this issue May 20, 2021
Merged
@chummels chummels self-assigned this May 23, 2021
Xarthisius added a commit to Xarthisius/yt that referenced this issue Jul 9, 2021
@Xarthisius
Use a fancier repr for labels in Profile/PhasePlots. Fixes yt-project…
20cbe6a 
…#3269
@Xarthisius Xarthisius mentioned this issue Jul 9, 2021
Merged
Xarthisius added a commit that referenced this issue Jul 9, 2021
@Xarthisius
Revert "Use a fancier repr for labels in Profile/PhasePlots. Fixes #3269
aa733c0 
"
munkm added a commit that referenced this issue Jul 9, 2021
@munkm
Merge pull request #3427 from yt-project/revert-3425-3269_pplot_zlabel
aaaf4d0 
Revert "Use a fancier repr for labels in Profile/PhasePlots. Fixes #3269"
@neutrinoceros neutrinoceros reopened this Jul 10, 2021
@neutrinoceros
Copy link
Member

It seems that this was fixed. Running your example again I get the expected result
galaxy0030_2d-Profile_density_temperature_H_p0_mass

@chummels
Copy link
Member Author

I think this got fixed in #3282.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chummels chummels

Labels
bug viz: 2D
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use a fancier repr for labels in Profile/PhasePlots. Fixes #3269 Xarthisius/yt
2 participants
@chummels @neutrinoceros