yt-4.0: disable testing on python2.7 #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
changed the title
|
I should also say that this also adds testing on python3.7 using the |
cphyc
approved these changes
Aug 22, 2018
brittonsmith
approved these changes
Aug 22, 2018
added 2 commits
August 22, 2018 12:42
matthewturk
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the tests only run on python3. I've kept the python2.7 linting stage to make backporting to the 3.x branch easier but now we don't run the unit tests. This should allow people to use python3-specific functionality as long as you don't use python3-specific syntax, which I think is a good compromise for now until we no longer support a maintenance branch that supports python2.7.