Add DerivedField.is_sph_field. Fixes #2069 #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ugh I have no idea why the plot answer tests are failing. Unfortunately there are some fixes for the answer test reporting script that are on master so I need to merge with master first to understand what's going on here. |
|
Other than those random failing tests this looks really good to me - I really like the idea behind this functionality |
AshKelly
approved these changes
Oct 19, 2018
matthewturk
approved these changes
Nov 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new property to the
DerivedFieldclass,is_sph_field. This isTrueis the field is an SPH field (i.e. it's ultimately an alias to a particle field where the particle type is an SPH particle type) andFalseotherwise. This simplifies logic in a few places and for free allows us to fix #2069 and better support particle filters made from an SPH particle type.I've also added a test.
ping @saethlin.