[yt-4.0] Merging with master #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[enhancement] Add relativistic component to cosmology calculations
address github vulnerability warning
1. Blocks were being read in the incorrect row/column ordering, which wasn't noticable with cubic blocks. 2. Handle root block splitting with one block in a dimension
…n previous commit.
Adding option to rotate arrows in the EPS writer
ensure the global namespace in the plugins file is preserved
Fixing enzo-p frontend bugs.
make FortranFile open files in binary mode. closes yt-project#2147
cphyc
approved these changes
Mar 1, 2019
|
@ngoldbaum -- do you want detailed review on this, or is test-passing sufficient? |
|
The tests passing should be sufficient. If you're worried take a look at the merge commit and the last couple of commits, the rest was all reviewed when it went on master. |
|
Should be good to go now :) OK to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once again trying to merge with master. Will push to this until I can get the tests passing.