Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix projection units #2175

Merged
merged 1 commit into from Mar 6, 2019
Merged

Fix projection units #2175

merged 1 commit into from Mar 6, 2019

Conversation

qobilidop
Copy link
Member

@qobilidop qobilidop commented Mar 5, 2019 •
edited

PR Summary

When a field's units and output_units are different, the SPH projection would make inconsistent assumptions. In this line, units is assumed, while in this line, output_units is assumed.

This fix makes sure output_units is used consistenely.

PR Checklist

  • Code passes flake8 checker
  • Adds a test for any bugs fixed

brittonsmith
brittonsmith approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@brittonsmith brittonsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

matthewturk
matthewturk requested changes Mar 5, 2019
View reviewed changes
Copy link
Member

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Minor stylistic nit.

yt/data_objects/construction_data_containers.py Show resolved Hide resolved
@qobilidop qobilidop mentioned this pull request Mar 5, 2019
Merged
5 tasks
@qobilidop qobilidop merged commit 74f9169 into yt-project:yt-4.0 Mar 6, 2019
@qobilidop qobilidop deleted the proj-units-fix branch March 6, 2019 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewturk matthewturk matthewturk approved these changes

@brittonsmith brittonsmith brittonsmith approved these changes

@chummels chummels chummels approved these changes

@ngoldbaum ngoldbaum Awaiting requested review from ngoldbaum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qobilidop @matthewturk @brittonsmith @chummels