-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SPH answer tests in yt-4.0 #2208
Conversation
So these modifications to
I suspect that this this has to do with the way the Tipsy datasets have to calculate their boundaries? I don't know much about this data at all, however. |
It's because that dataset doesn't have periodic boundary conditions and something in the test is causing a read outside the boundary. Should probably be looked into more. |
@ngoldbaum for this PR or separate? |
It doesn't really matter. If you want we can merge this now and come back to it in the context of the PR merging with master. |
Selfishly, I'd prefer the latter so we can also get the Arepo PR merged in. |
I don't think this needs to be merged before the arepo one. |
Well, the only way to make sure the Arepo tests pass is to merge this one first. No hurry of course. |
That would be true if we were running the SPH answer tests, which we aren't right now. This one only needs to be merged before we get rid of the yt-4.0 branch. |
@jzuhone I'm not entirely sure that I understand how to fix the issue of growing the domain, which I think is what's happening here. Perhaps the simplest thing to do would be to -- for cases that are non-periodic and particle-based -- just say it's okay if we read outside the domain for particle fields. |
@jzuhone I think a check for the region to see if the |
This is ready to go, we can handle the Tipsy issue separately. |
The
sph_answer
tests need updating for yt-4.0. This PR is a WIP to update them. Things that have to be done:sph_answer
)