disable OSNI projection answer test #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
In the cartopy testing file we've disabled the OSNI projection in the unit tests due to potential incompatibilities that might be caused with shapely/GEOS. However, this wasn't done in the answer tests. I'm guessing that we've been lucky so far to not have encountered this failure, because it was an issue when we first added cartopy support. I think because we've disabled this projection in the unit tests, it's reasonable to also do it in the answer tests. I've also included a link to the issue as a comment line in the test so it's clear why we've disabled it.
PR Checklist