[AMRVAC] bugfix geometry parsing #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a ValueError to be raised
matthewturk
approved these changes
Apr 14, 2020
There was a problem hiding this comment.
This looks fine, but I wonder if it would be cleaner to have it be a dict that gets accessed, and then let the KeyError propagate instead. That would push the geometry_yt result back up to the user to see. So for instance:
geometry_yt = {'default': 'cartesian', ...}[geometry_tag.split("_")[0].lower()]
|
So... something like this ? |
|
I like it! |
munkm
approved these changes
Apr 14, 2020
|
I don't think it's well known. I just discovered it myself and I think that prior to the yt frontend, almost nobody in the community was using the native data files for analysis anyway... well, I'm adding the note then 😅 edit: whoops, the docstring was also containing a now irrelevant Raises section |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hotfix a bug in amrvac frontend where 'default' geometry would cause a ValueError to be raised.