Put answers in submodule in yt-4.0 #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewturk
added
tests: running tests
|
Ok, so the tests are failing at the linter on Travis because this branch doesn't have the updates from #2513. Ugh. @matthewturk are the tests that this is pointing to identical to the ones that already exist in answer-store on yt-4.0? Perhaps we can merge this one now, update 2513, and (if needed) do a separate PR to update the tests in |
munkm
approved these changes
Apr 15, 2020
| [submodule "answer-store"] | ||
| path = answer-store | ||
| url = https://github.com/yt-project/answer-store | ||
| branch = yt-4.0 |
There was a problem hiding this comment.
+1 to using a separate branch for these tests. Then we can have updates for tests on master too and after the 4.0 merge we won't have annoying history conflicts.
Maybe we'll also need a 4.0 merge PR for the answer store then, too? 😉
|
I think that's *exactly* what we should do!
…On Wed, Apr 15, 2020 at 11:52 AM Madicken Munk ***@***.***> wrote:
Ok, so the tests are failing at the linter on Travis because this branch
doesn't have the updates from #2513
<#2513>. Ugh. @matthewturk
<https://github.com/matthewturk> are the tests that this is pointing to
identical to the ones that already exist in answer-store on yt-4.0? Perhaps
we can merge this one now, update 2513, and (if needed) do a separate PR to
update the tests in answer-store to fix failures. What do you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2546 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVXO4COUJB5JXLXY6Z5FTRMXQ47ANCNFSM4MIWWPJA>
.
|
Xarthisius
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #2545, but for yt-4.0.
I re-used the git module from my master checkout, so hopefully this will be fine!
What I'm planning to do is see if Travis complains -- it should about wrong answers, but not missing answers -- and then if it does, update the answers in https://github.com/yt-project/answer-store/ in the yt-4.0 branch, then update here.