Avoid importing 'yt' deep in the code base #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munkm
approved these changes
May 8, 2020
munkm
added
enhancement
matthewturk
reviewed
May 15, 2020
|
@Xarthisius can you update the conflicts? |
Xarthisius
force-pushed
the
pytest_fix
branch
3 times, most recently
from
1f27262
to
43fc2aa
Compare
|
/format |
neutrinoceros
approved these changes
Aug 11, 2020
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
It would be nice if we could avoid doing
import ytwithin the yt submodules themselves. I noticed it was happening solely due toyt._called_from_pytest, which I think can be achieved using existing config idiom used with nose.