Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract some particle tests #2617

Merged
merged 6 commits into from
Jun 18, 2020
Merged

Abstract some particle tests #2617

merged 6 commits into from
Jun 18, 2020

Conversation

matthewturk
Copy link
Member

This starts to pull some code out of the particle tests specifically and putting them in the base class, as per #2616 .

Please feel free to push to this branch.

@matthewturk matthewturk added index: particle infrastructure Related to CI, versioning, websites, organizational issues, etc tests: running tests Issues with the test setup labels Jun 5, 2020
@matthewturk
Copy link
Member Author

In this PR I've abstracted the basic tests that I used in gadget, so now it should be sufficient to get decent coverage by just calling run_defaults.

munkm
munkm reviewed Jun 8, 2020
View reviewed changes
Copy link
Member

@munkm munkm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need tests for open_pmd, sph, and yt_data, or are those not necessary?

yt/testing.py Show resolved Hide resolved
yt/testing.py Show resolved Hide resolved
yt/frontends/owls/tests/test_outputs.py Show resolved Hide resolved
@matthewturk
Copy link
Member Author

They aren't necessary after all.

@matthewturk matthewturk mentioned this pull request Jun 9, 2020
Merged
@munkm munkm added the yt-4.0 feature targeted for the yt-4.0 release label Jun 11, 2020
@munkm munkm merged commit 44eb8a8 into yt-project:yt-4.0 Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munkm munkm munkm approved these changes

@cphyc cphyc cphyc approved these changes

Assignees
No one assigned
Labels
index: particle infrastructure Related to CI, versioning, websites, organizational issues, etc tests: running tests Issues with the test setup yt-4.0 feature targeted for the yt-4.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewturk @cphyc @munkm