fix flake8-bugbear B001 (bare excepts) (YTEP0037 6/6 part 5) #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
enhancement
9 tasks
cphyc
approved these changes
Jul 16, 2020
neutrinoceros
force-pushed
the
bugfix_b001_errors
branch
from
d0a985e
to
af27f0d
Compare
matthewturk
approved these changes
Jul 19, 2020
| @@ -56,9 +56,8 @@ def _is_valid(self, *args, **kwargs): | |||
| ) | |||
| ) | |||
| fh.close() | |||
| except: | |||
| except Exception: | |||
There was a problem hiding this comment.
Oof, I'm glad we're adding Exception but we should probably improve this. (I know you made this easier to improve in your load refactor work.)
There was a problem hiding this comment.
Yes, it's also one of the goals on this PR: #2760 !
neutrinoceros
force-pushed
the
bugfix_b001_errors
branch
from
af27f0d
to
0224312
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This partly addresses #2666, namely B001 "bare excepts".
This is also a follow up to #2474, and it shows that these kind of code degradation will continue to pop up until we have a linting tool to catch them (flake8-bugbear does the job here !)