fix flake8-bugbear B010 errors (YTEP0037 6/6 part 6) #2672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
enhancement
9 tasks
cphyc
approved these changes
Jul 16, 2020
neutrinoceros
changed the title
neutrinoceros
force-pushed
the
bugfix_b010_errors
branch
from
c451154
to
f11dc23
Compare
matthewturk
approved these changes
Jul 19, 2020
| "_ipython_display_", | ||
| functools.partial(_wrap_display_ytarray, ret), | ||
| ) | ||
| ret._ipython_display_ = functools.partial(_wrap_display_ytarray, ret) |
There was a problem hiding this comment.
I think I wrote this code, and I think I had a reason for using setattr but for the life of me I can't remember, so 🤷
There was a problem hiding this comment.
I'll take the blame it this ever breaks :)
neutrinoceros
force-pushed
the
bugfix_b010_errors
branch
from
f11dc23
to
a82ddec
Compare
Xarthisius
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This partly addresses #2666, namely B010 "Do not call setattr with a constant attribute value"