Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add flake8-bugbear to travis linting (YTEP0037 6/6 part 0) #2674

Merged
merged 2 commits into from
Jul 23, 2020

Conversation

neutrinoceros
Copy link
Member

PR Summary

This PR adds flake8-bugbear to the linting stage for Travis. CI should fail until PRs attached to #2666 are merged.

@neutrinoceros neutrinoceros added enhancement Making something better infrastructure Related to CI, versioning, websites, organizational issues, etc code style Related to linting tools labels Jun 23, 2020
@neutrinoceros neutrinoceros added the yt-4.0 feature targeted for the yt-4.0 release label Jun 25, 2020
@neutrinoceros neutrinoceros force-pushed the ci_add_bugbear branch 2 times, most recently from 41a0144 to 59cab01 Compare July 17, 2020 19:28
@matthewturk
Copy link
Member

Just so I understand, we expect this to fail until the other bits in the series go in, right?

@neutrinoceros
Copy link
Member Author

Just so I understand, we expect this to fail until the other bits in the series go in, right?

exactly ! that's test-driven dev for you 😄

@neutrinoceros
Copy link
Member Author

neutrinoceros commented Jul 22, 2020

Alright so only #2667 is still not merged (tests are running), so I've made this branch a continuation of it, and bugbear checks should now pass here.

@neutrinoceros
Copy link
Member Author

@yt-fido test this please

@matthewturk matthewturk merged commit 53b2d0a into yt-project:master Jul 23, 2020
@neutrinoceros neutrinoceros deleted the ci_add_bugbear branch July 23, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code style Related to linting tools enhancement Making something better infrastructure Related to CI, versioning, websites, organizational issues, etc yt-4.0 feature targeted for the yt-4.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants