[BUGFIX] Fix athena and gizmo tests #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cphyc
reviewed
Jun 24, 2020
| @@ -80,7 +80,7 @@ def test_gas_particle_fields(): | |||
|
|
|||
| ptype = "gas" | |||
| derived_fields = [] | |||
| for species in ["H", "H_p0", "H_p1"]: | |||
| for species in ["H_p0", "H_p1"]: | |||
There was a problem hiding this comment.
What is the rationale behind not testing "H" anymore?
There was a problem hiding this comment.
It doesn't exist anymore #2336
cphyc
approved these changes
Jun 24, 2020
munkm
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This should fix the Athena and Gizmo errors appearing in #2677.