Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YTEP0037 application: transition to black + isort #2749

Merged
merged 4 commits into from
Jul 17, 2020
Merged

YTEP0037 application: transition to black + isort #2749

merged 4 commits into from
Jul 17, 2020

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Jul 16, 2020 •
edited
Loading

This contains the actual transition to isort + black after #2592 and #2596 were merged with all the required configuration.

@neutrinoceros neutrinoceros added enhancement Making something better code style Related to linting tools labels Jul 16, 2020
@neutrinoceros neutrinoceros mentioned this pull request Jul 16, 2020
Closed
@neutrinoceros neutrinoceros marked this pull request as draft July 16, 2020 19:41
@neutrinoceros neutrinoceros marked this pull request as ready for review July 16, 2020 20:10
@neutrinoceros
Copy link
Member Author

just rebased after faking authorship of the huge commits.
I also added a .git-blame-ignore-revs file to mark these commits as ignorable by git blame, see https://github.com/psf/black#migrating-your-code-style-without-ruining-git-blame

I consider this mergeable now !

@neutrinoceros neutrinoceros changed the title Ytep0037 application YTEP0037 application: transition to black + isort Jul 17, 2020
@matthewturk matthewturk merged commit fdc9210 into yt-project:master Jul 17, 2020
This was referenced Jul 18, 2020
Merged
Merged
@neutrinoceros neutrinoceros deleted the ytep0037-application branch July 21, 2020 12:28
@neutrinoceros neutrinoceros mentioned this pull request Jul 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code style Related to linting tools enhancement Making something better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neutrinoceros @matthewturk