-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Dataset._get_field_info() error message for unfindable field #2775
Fix Dataset._get_field_info() error message for unfindable field #2775
Conversation
Hey I'm just moving the enhancement label on this because when we do our release notes this should be categorized as a bug. |
e06f523
to
aba617c
Compare
@FIdo test this please |
@yt-fido test this please |
1 similar comment
@yt-fido test this please |
…guess the ftype, the error message shows the user input instead of the latest internal attempt
f22c193
to
7411feb
Compare
quick note that once this is approved and merged, we should take another look at broken examples in #2723, two of which are failing with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Some of this logic could be avoided if we did not allow for ambiguous field access.
PR Summary
Currently, when
Dataset._get_field_info()
is fed bad data (unfindable field), it raises an error which contains a seemingly randomftype
value, unrelated to external input.This fixes it
PR Checklist
flake8 yt/
isort . --check --diff
black --check yt/