Rearrange index component objects #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
approved these changes
Aug 13, 2020
|
Merge worked OK here when I pulled ... so hopefully it worked when I pushed? |
cphyc
approved these changes
Sep 14, 2020
cphyc
approved these changes
Sep 14, 2020
|
I think I added this to make sure that the object registered correctly.
…On Mon, Sep 14, 2020 at 10:58 AM Corentin Cadiou ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In yt/data_objects/index_subobjects/__init__.py
<#2829 (comment)>:
> @@ -0,0 +1,2 @@
+from .grid_patch import AMRGridPatch
Is this required? It seems the only place it is imported from is in
yt/data_objects/api.py above.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2829 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVXO3DBLMT5K2I4HUQDPTSFY4SVANCNFSM4PX6V5JA>
.
|
Fair enough! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In support of #2827, this moves the data objects that are strictly subobjects of index objects (i.e., grid patches, unstructured mesh index objects, etc) into their own package and subdirectory.
This may need rebasing or reworking if #2828 is accepted.