Deactivate coverage badge #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
added
proposal
neutrinoceros
force-pushed
the
deactivate_coverage_badge
branch
from
ad9e90f
to
937ef95
Compare
neutrinoceros
force-pushed
the
deactivate_coverage_badge
branch
from
937ef95
to
9044335
Compare
matthewturk
approved these changes
Aug 12, 2020
|
ping @Xarthisius |
Xarthisius
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The coverage badge is currently essentially useless since we do not upload test reports at the moment.
I think it'd be preferable to deactivate it until we have a way of generating coverage reports that doesn't significantly impede the CI speed.
Not really a "fix", but related to #2780