Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to strictly enforce requires_file #2884

Merged
merged 1 commit into from
Sep 1, 2020
Merged

Add an option to strictly enforce requires_file #2884

merged 1 commit into from
Sep 1, 2020

Conversation

Xarthisius
Copy link
Member

PR Summary

This allows to detect missing files called by requires_file on Jenkins

PR Checklist

  • pass black --check yt/
  • pass isort . --check --diff
  • pass flake8 yt/
  • pass flynt yt/ --fail-on-change --dry-run -e yt/extern
  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

@Xarthisius Xarthisius added enhancement Making something better tests: running tests Issues with the test setup labels Aug 18, 2020
neutrinoceros
neutrinoceros approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@neutrinoceros neutrinoceros left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that will come in handy !
Not strictly in the scope of this PR, but do you think it would be doable to change @requires_ds and @requires_file so that a test is skipped rather than passed when data is in fact missing but the strict option is off ?

@neutrinoceros
Copy link
Member

Never mind the above comment, I've issued this as a separate PR #2885 .
So if I'm following, this exposes the failures fixed by #2883, and should be merged after a rerun ?

@munkm munkm merged commit dcac6d1 into yt-project:master Sep 1, 2020
@Xarthisius Xarthisius deleted the strict_requires branch September 1, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neutrinoceros neutrinoceros neutrinoceros approved these changes

@munkm munkm munkm approved these changes

Assignees
No one assigned
Labels
enhancement Making something better tests: running tests Issues with the test setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xarthisius @neutrinoceros @munkm