Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

futurefix: fix a deprecation warning from mpl 3.3 #2944

Merged
merged 3 commits into from
Nov 17, 2020
Merged

futurefix: fix a deprecation warning from mpl 3.3 #2944

merged 3 commits into from
Nov 17, 2020

Conversation

neutrinoceros
Copy link
Member

PR Summary

the warning in question is seen in Jenkins logs, e.g.

/home/fido/workspace/yt_py38_git/yt/visualization/base_plot_types.py:274:
MatplotlibDeprecationWarning: Passing parameters norm and vmin/vmax simultaneously is deprecated since 3.3 
and will become an error two minor releases later. Please pass vmin/vmax directly to the norm when creating it.
  self.image = self.axes.imshow(

@neutrinoceros neutrinoceros added bug api-consistency naming conventions, code deduplication, informative error messages, code smells... labels Oct 14, 2020
@neutrinoceros
Copy link
Member Author

This now also includes a fix for a bug that was due to overlooked copy-pasted code.

cphyc
cphyc approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@cphyc cphyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one comment, you can decide if you want it in by accepting it, or simply ignore it by marking the discussion as resolved. Either way, I'm ok with merging the PR!

yt/visualization/base_plot_types.py Show resolved Hide resolved
yt/visualization/base_plot_types.py Outdated Show resolved Hide resolved
@neutrinoceros @cphyc
don't use dict update for a single static key/value pair
15b3a9e 
Co-authored-by: Corentin Cadiou <contact@cphyc.me>
@munkm munkm merged commit 94aedbc into yt-project:master Nov 17, 2020
@neutrinoceros neutrinoceros deleted the fix_mpl_depre_warning branch December 16, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munkm munkm munkm approved these changes

@cphyc cphyc cphyc approved these changes

@Xarthisius Xarthisius Xarthisius approved these changes

Assignees
No one assigned
Labels
api-consistency naming conventions, code deduplication, informative error messages, code smells... bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neutrinoceros @Xarthisius @cphyc @munkm