Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix installation against python 3.9 #2975

Merged
merged 1 commit into from
Nov 23, 2020
Merged

fix installation against python 3.9 #2975

merged 1 commit into from
Nov 23, 2020

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Nov 22, 2020 •
edited
Loading

PR Summary

fix #2974

@neutrinoceros neutrinoceros added bug infrastructure Related to CI, versioning, websites, organizational issues, etc labels Nov 22, 2020
@neutrinoceros neutrinoceros marked this pull request as ready for review November 22, 2020 23:42
cphyc
cphyc approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@cphyc cphyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Note that interestingly, it seems that yt is working faster on Python 3.9 than on Python 3.7.7. More thorough tests would be required to confirm this though.

pyproject.toml
@@ -7,8 +7,7 @@ requires = [
# keep in sync with travis.yml "minimal" specs (Cython and numpy for py36)
"Cython>=0.26.1",
"numpy==1.13.3; python_version=='3.6' and platform_system!='AIX'",
"numpy==1.18.1; python_version=='3.7' and platform_system!='AIX'",
"numpy==1.18.4; python_version=='3.8' and platform_system!='AIX'",
"numpy>=1.18.4; python_version>='3.7' and platform_system!='AIX'",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but together with #2917 , why don't we add support for Python 3.9 in the CI altogether?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course that's the next step, but I'd rather have the bug fix go in asap while the testing can wait imo :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough!

@cphyc cphyc merged commit 06c3804 into yt-project:master Nov 23, 2020
@neutrinoceros neutrinoceros deleted the hotfix_install_py39 branch November 23, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cphyc cphyc cphyc approved these changes

Assignees
No one assigned
Labels
bug infrastructure Related to CI, versioning, websites, organizational issues, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installation is broken against python 3.9
2 participants
@neutrinoceros @cphyc