Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flynt+flake+isort doc #2983

Merged
merged 8 commits into from
Dec 16, 2020
Merged

Flynt+flake+isort doc #2983

merged 8 commits into from
Dec 16, 2020

Conversation

cphyc
Copy link
Member

@cphyc cphyc commented Nov 25, 2020

PR Summary

Apply fint to the doc and fix a couple of isort/flake8 issues there.
On a side note, there are many files that depend on hg which we haven't been using for years now. Should we clean them up?

@cphyc cphyc changed the title Flynt doc Flynt+flake+isort doc Nov 25, 2020
@cphyc cphyc added code style Related to linting tools enhancement Making something better labels Nov 25, 2020
@cphyc cphyc mentioned this pull request Nov 25, 2020
Merged
6 tasks
@neutrinoceros
Copy link
Member

Thanks for doing this ! Could you also add doc to the targeted locations in the precommit hooks and gh workflow checks ?

@neutrinoceros neutrinoceros added the dead code removing internal bits that have no effect label Nov 26, 2020
@neutrinoceros
Copy link
Member

adding the dead code label because of 3171ebc

neutrinoceros
neutrinoceros approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this, I carefully went over it and I approve fully.

@neutrinoceros
Copy link
Member

On a side note, there are many files that depend on hg which we haven't been using for years now. Should we clean them up?

I think @matthewturk could answer this question !

@matthewturk
Copy link
Member

I'm OK with removing the hg-related files and support tools, but maybe in a separate PR.

@matthewturk matthewturk merged commit 321bcc4 into yt-project:master Dec 16, 2020
@cphyc cphyc deleted the flynt-doc branch December 16, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neutrinoceros neutrinoceros neutrinoceros approved these changes

@matthewturk matthewturk matthewturk approved these changes

Assignees
No one assigned
Labels
code style Related to linting tools dead code removing internal bits that have no effect enhancement Making something better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cphyc @neutrinoceros @matthewturk @yt-fido