Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Fix figure width in HTML output #3019

Merged
merged 1 commit into from
Jan 11, 2021
Merged

[BUGFIX] Fix figure width in HTML output #3019

merged 1 commit into from
Jan 11, 2021

Conversation

cphyc
Copy link
Member

@cphyc cphyc commented Jan 10, 2021

PR Summary

There is a minor mistake in the HTML representation of images that prevents the max-width to be correctly set to "100%". This PR fixes it.

@cphyc cphyc added the bug label Jan 10, 2021
matthewturk
matthewturk approved these changes Jan 10, 2021
View reviewed changes
Copy link
Member

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes both look good to me, but can you rename the PR so it has both components?

neutrinoceros
neutrinoceros approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@neutrinoceros neutrinoceros left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+ 1 Matt

edit: looks like a branching mistake following #3018 actually
@cphyc , I'm guessing nothing needs to be touched, and we can solve this by merging #3018 first

@neutrinoceros
Copy link
Member

Welp the diff is still showing change I just merged in the #3018, I'm not getting it 🙃

@cphyc
Copy link
Member Author

cphyc commented Jan 11, 2021

I've rebased, that should be good now!

@neutrinoceros neutrinoceros merged commit 51a28f5 into yt-project:master Jan 11, 2021
@cphyc cphyc deleted the fix/figure_width branch January 11, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neutrinoceros neutrinoceros neutrinoceros approved these changes

@matthewturk matthewturk matthewturk approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cphyc @neutrinoceros @matthewturk