[BUGFIX] Support old gcc versions #3072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag may not be enough, but its support is a necessary condition
matthewturk
approved these changes
Feb 10, 2021
cphyc
force-pushed
the
support-old-gcc
branch
from
715589a
to
947b7aa
Compare
|
Following up our Slack conversation, this fix for gcc version ultimately doesn't solve the error that I get when I try to load yt in Python. Briefly, the error is Edit: This error is from #3050 and the fix is to update numpy to at least 1.20.0. |
neutrinoceros
approved these changes
Feb 10, 2021
Co-authored-by: Clément Robert <cr52@protonmail.com>
Co-authored-by: Clément Robert <cr52@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some files require some C++14 features which aren't supported on old versions of GCC. This PR tries to find the most suitable compiler flags to supports these features (though it does not capture all cases).
I tested this PR with GCC 4.7.4 (can now compile yt, could not before). With GCC 4.6.4 and older versions, the compilation fails as the support for C++14 is unsufficient to compile yt.
Fixes #3071.