-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mistake in call to partial function #3081
Fix mistake in call to partial function #3081
Conversation
At the moment, the test(s) are not triggered at all. I'm working on it but in the meantime I'm switching to draft. |
@matthewturk @brittonsmith @neutrinoceros this is ready to go (I just need to bump the answer tests for Jenkins). However, it seems #3087 would require bumping the answer tests again. My question is thus: should we fix #3087 in this PR before merging or submit the answer tests knowing the velocities may be off? |
I think whatever gets this in and closed is best. |
We lost the report, I need to rerun tests |
I think it's fine to not fix #3087 in this PR. We can do a follow up PR for that, and now that we have the submodule for answers I don't think it's a huge issue to have lots of answer-store commits. Unless I'm missing something? |
FWIW, I think it's already hard enough to properly handle a single PR there at a time, I don't think anyone wants to abuse them if it can be avoided. But if we need 2 updates instead of one, that's fine by me :) |
PR Summary
This bug was reported by @claytonstrawn on our channel. It is due to a minor typo in the way art deals with particle velocity fields which caused a Python error.
Steps to reproduce:
PR Checklist