Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a NameError in yt.mods #3083

Merged
merged 1 commit into from
Feb 24, 2021
Merged

fix a NameError in yt.mods #3083

merged 1 commit into from
Feb 24, 2021

Conversation

neutrinoceros
Copy link
Member

PR Summary

I'm not actually convinced that the file should be kept (dead code ?) but it's easy enough to fix the NameError one gets with import yt.mods atm

@neutrinoceros neutrinoceros added bug question dead code removing internal bits that have no effect labels Feb 22, 2021
matthewturk
matthewturk approved these changes Feb 24, 2021
View reviewed changes
Copy link
Member

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think removing mods is a good first-after-4 change. Thanks for fixing this.

@matthewturk matthewturk merged commit fa8a731 into yt-project:main Feb 24, 2021
@neutrinoceros neutrinoceros deleted the fix_mods_module branch February 24, 2021 11:51
@neutrinoceros neutrinoceros mentioned this pull request Feb 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewturk matthewturk matthewturk approved these changes

Assignees
No one assigned
Labels
bug dead code removing internal bits that have no effect question
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neutrinoceros @matthewturk