Make config related paths dynamical. Fixes #3104 #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xarthisius
force-pushed
the
config_safety
branch
from
7255222
to
49bfe83
Compare
|
Not sure if it helps, but pooch (an optional dependency for yt) depends on appdirs which abstracts this a bit. |
Xarthisius
force-pushed
the
config_safety
branch
from
953ee21
to
0fa4b90
Compare
| from yt.testing import assert_raises, fake_random_ds | ||
|
|
||
| XDG_CONFIG_HOME = os.environ.get("XDG_CONFIG_HOME") |
There was a problem hiding this comment.
why isn't this part of the test setup ?
There was a problem hiding this comment.
What's the difference? It's not going to be imported by anything
There was a problem hiding this comment.
You're right, but in this state it looks like it's going to be used in more than one test (which would make it a candidate for fixture in pytest), but it's not the case, so might as well define it in the only scope it used.
matthewturk
approved these changes
Mar 8, 2021
Xarthisius
force-pushed
the
config_safety
branch
from
a2991a6
to
2c09502
Compare
munkm
approved these changes
Mar 8, 2021
Sanitize conf/plugin handling in tests
Xarthisius
force-pushed
the
config_safety
branch
from
2c09502
to
b230cc5
Compare
neutrinoceros
approved these changes
Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR ensures that every time a "config path" is requested it respects the current value of XDG_HOME_DIR.