Fix field parameters not working with off axis projections #3147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is an attempt to fix issue #3126 to ensure that field parameters can be used with off-axis projections.
This is a work in progress.I think that I only need to restore the underscore that was removed in this commit:
cde25a8#diff-2d1d24ee7df2e3b516614aad6fa0d7bd09a0268684a1c6b748eee75c1b823002
which is here, in line 57:
yt/yt/visualization/volume_rendering/render_source.py
Lines 52 to 65 in bc33f4e
but it sounds like with it in there other things were broken, so we're going to see what happens with the tests.
EDIT: All tests pass with just this one commit.
PR Checklist