fix: typing for Dataset.cosmological_simulation #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
neutrinoceros
force-pushed
the
cosmo_int
branch
from
fc503aa
to
490c135
Compare
…float split poorly formatted statements into separate lines
neutrinoceros
force-pushed
the
cosmo_int
branch
from
23d7ff7
to
ed3ae3f
Compare
matthewturk
approved these changes
Mar 29, 2021
|
What do you mean ? |
|
I mean, this is a good reason to change it to an int everywhere. That's
all. :-)
…On Mon, Mar 29, 2021 at 5:22 AM Clément Robert ***@***.***> wrote:
What do you mean ?
My personal opinion is that this parameter *should* probably be a bool,
but I don't know why it was made an int in the first place so I'm not
questioning it here. In any case it's *documented* as an int.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3156 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVXO5J7HK34GMVN4IJMRTTGBPI3ANCNFSM4Z6O25AA>
.
|
brittonsmith
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This attribute is supposed to be an int and is wrongly set to a float in some frontends.
It should really be an bool but that's beyond the scope of this PR
edit: while I'm at it I split separate statements into separate lines to clarify formatting in these regions