Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a pytest-compatible version of requires_module #3159

Merged
merged 2 commits into from
Apr 7, 2021

Conversation

neutrinoceros
Copy link
Member

PR Summary

This function is meant as a drop-in replacement for the existing required_module decorator.
The end goal is to provide a pytest-compatible alternative (and eventual replacement when nose is dropped).
While I'm at it, and since it's relevant in the context of #3089 (containing the initial implementation), I added support for
an arbitrary number of arguments as an alternative to decorator stacking.

It is under testing in #3089 at the time of writing, and I confirm that it works as intended locally.

@neutrinoceros neutrinoceros added infrastructure Related to CI, versioning, websites, organizational issues, etc refactor improve readability, maintainability, modularity pytest labels Mar 30, 2021
yt/testing.py Outdated Show resolved Hide resolved
@munkm munkm merged commit ab20911 into yt-project:main Apr 7, 2021
@neutrinoceros neutrinoceros deleted the requires_modules_pytest branch April 7, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to CI, versioning, websites, organizational issues, etc pytest refactor improve readability, maintainability, modularity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants