Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow brew to update to fix hdf5 installation issues #3187

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

cphyc
Copy link
Member

@cphyc cphyc commented Apr 12, 2021

PR Summary

Tries to make the OSx test run again by allowing brew to update itself.

The origin of the bug is due to:

  1. hdf5 requires a library called szip
  2. szip depends on a compiled binary that was hosted on bintray
  3. which depends on jfrog.com, who announced recently they were dropping support for bintray (https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/).

This has been fixed quite a while ago (see the file history of https://github.com/Homebrew/homebrew-core/blob/master/Formula/szip.rb), but we still need to have brew update its recipe cache for it to take into account.

@cphyc cphyc added blocker Highest priority level bug labels Apr 12, 2021
@cphyc cphyc changed the title Allow bres to update to fix hdf5 installation issues Allow brew to update to fix hdf5 installation issues Apr 12, 2021
@cphyc
Copy link
Member Author

cphyc commented Apr 12, 2021

Note: a side effect is that it now takes +10min for the OSX build to set things up and actually start compiling yt.

@cphyc cphyc added the infrastructure Related to CI, versioning, websites, organizational issues, etc label Apr 12, 2021
Copy link
Member

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sad but necessary.

@cphyc
Copy link
Member Author

cphyc commented Apr 12, 2021

Note: if one day the version of brew installed by default on the OSX image shipped with Github action is recent enough, the changes in this PR may not be required any more.

However, since we have no control on this image, I don't think we should count on it in the foreseeable future.

@cphyc cphyc marked this pull request as ready for review April 12, 2021 17:22
@neutrinoceros neutrinoceros merged commit 0dcd88c into yt-project:main Apr 12, 2021
@cphyc cphyc deleted the fixing-brew branch October 19, 2021 15:41
neutrinoceros added a commit to neutrinoceros/yt that referenced this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Highest priority level bug infrastructure Related to CI, versioning, websites, organizational issues, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants