Fix print_stats function for RAMSES datasets.
#3196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure the new test is actually preventing this kind of bug to reappear. Can you add a note we should use capsys to actually test the output (when pytest is our only test runner) ? |
munkm
approved these changes
Apr 13, 2021
| @@ -638,7 +638,7 @@ def test_max_level(): | |||
| assert any(ds.r["index", "grid_level"] == 2) | |||
|
|
|||
|
|
|||
| @requires_file(ramses_new_format) | |||
| @requires_file(output_00080) | |||
| def test_print_stats(): | ||
| ds = yt.load(ramses_new_format) | ||
|
|
||
| # Should work |
|
I should have written it more clearly, but when I say broken I mean it raises an exception. |
neutrinoceros
approved these changes
Apr 13, 2021
neutrinoceros
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The
print_statsfunction is broken for RAMSES datasets.PR Checklist