[bugfix] Allow the magnetic field unit to be set from unit_base in all Gadget-based frontends #3233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
approved these changes
Apr 29, 2021
Xarthisius
approved these changes
Apr 29, 2021
|
@jzuhone do you plan to add tests to this or should we merge it? |
|
@munkm I think this one should just be merged. We need to have a dataset which needs this functionality added to the tests. I have one, but I'll add it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The GIZMO frontend by default sets the magnetic field code unit to be 1.0 Gauss, but it says here you can set the value of the magnetic unit to something else. This PR allows for that by adding the code to set the magnetic field from
unit_basein the Gadget frontend, but the "sane default" is still 1.0 Gauss.PR Checklist