Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set correct periodicity attribute. #3285

Merged
merged 1 commit into from
May 20, 2021
Merged

Set correct periodicity attribute. #3285

merged 1 commit into from
May 20, 2021

Conversation

brittonsmith
Copy link
Member

PR Summary

Set _periodicity instead of periodicity.

PR Checklist

  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

@brittonsmith brittonsmith added bug code frontends Things related to specific frontends labels May 20, 2021
neutrinoceros
neutrinoceros approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed the correct fix, thanks for catching it !

@neutrinoceros
Copy link
Member

neutrinoceros commented May 20, 2021 •
edited
Loading

I'm surprised that this seems to raise not conflict since #3273 was merged already.
@brittonsmith, maybe you local copy is slightly behind ?

@chummels
Copy link
Member

I see this working on the enzo-e frontend, so it seems like he's up to date.

@neutrinoceros
Copy link
Member

I see this working on the enzo-e frontend, so it seems like he's up to date.

right, I got this wrong. Sorry for reviewing before my first coffee guys :)

@neutrinoceros neutrinoceros merged commit 50145ea into yt-project:main May 20, 2021
@brittonsmith brittonsmith deleted the eeper branch May 21, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neutrinoceros neutrinoceros neutrinoceros approved these changes

@chummels chummels chummels approved these changes

Assignees
No one assigned
Labels
bug code frontends Things related to specific frontends
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brittonsmith @neutrinoceros @chummels