Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
With the release of numpy 1.21, the following answer tests finale images changed slightly
yt/visualization/tests/test_plotwindow.py:test_attributes_wt
here's the existing reference
and here's the new result
Here's a minimal script to reproduce this (thanks @Xarthisius for posting this on Slack)
The actual range in the data is [0.05956075, 6.61460495] (g/cm^3), so the resulting image is kinda irrelevant in both cases and the new one is actually consistent with what can be obtained with a very simple, pure mpl + numpy example script:
My conclusion is that there is nothing to fix on our side so we can simply bump our answers and call it a day.
update: as discussed on Slack with @Xarthisius and @jzuhone , I've updated the PR to simply drop the problematic test.