MNT: migrate away from packaging.version.parse #3494
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Currently,
packaging.version.parse_version
is implemented asbut
LegacyVersion
is deprecated since pypa/packaging#342and the plan for their next release is to have
packaging.version.parse
basically be an alias forpackaging.version.Version.__init__
, see pypa/packaging#407So I'm proposing we move forward with it and stop using the
parse
function as it may cause confusion in the future and is more complicated to use.Note that since we're now treating warnings as errors in CI (#3380) means that we can switch with confidence because we know that we don't currently have any such warnings to deal with.