Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR #3424 on branch yt-4.0.x (implement AthenaDataset._is_valid) #3572

Merged
merged 1 commit into from
Oct 16, 2021
Merged

Backport PR #3424 on branch yt-4.0.x (implement AthenaDataset._is_valid) #3572

merged 1 commit into from
Oct 16, 2021

Conversation

meeseeksmachine
Copy link

Backport PR #3424: implement AthenaDataset._is_valid

@lumberbot-app lumberbot-app bot added bug tests: running tests Issues with the test setup labels Oct 15, 2021
@neutrinoceros neutrinoceros added this to the 4.0.2 milestone Oct 15, 2021
@neutrinoceros neutrinoceros reopened this Oct 16, 2021
@neutrinoceros neutrinoceros mentioned this pull request Oct 16, 2021
Merged
@neutrinoceros
Copy link
Member

neutrinoceros commented Oct 16, 2021 •
edited
Loading

the failure is unrelated, due to a mishap in the merging order of backport PRs. #3533 was already back ported to the 4.0.x branch but #3550 wasn't, so the test references are currently out of sync.

@neutrinoceros
Copy link
Member

The one failed test is unrelated to this PR, and due to an unfortunate ordering in merging backports. It was fixed by #3597

@neutrinoceros neutrinoceros merged commit 4bd45bb into yt-project:yt-4.0.x Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug tests: running tests Issues with the test setup
Projects
None yet
Milestone
4.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@meeseeksmachine @neutrinoceros @jzuhone