Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix LaTeX typesetting for fractional ylabels in LinePlot #3637

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

neutrinoceros
Copy link
Member

PR Summary

Goal: fix #3636
I'm cargo culting a bit here, so I'll open as a draft.

@neutrinoceros
Copy link
Member Author

The fact that this passed the answer job shows that it's not yet fixing the targeted problem.

@neutrinoceros neutrinoceros force-pushed the fix_ylabel_frac branch 2 times, most recently from 7ace649 to 7971b48 Compare November 1, 2021 09:32
@neutrinoceros
Copy link
Member Author

Got the right fix, rebased.

@neutrinoceros neutrinoceros changed the title BUG: fix LaTeX typesetting for fractional ylabels in ProfilePlot BUG: fix LaTeX typesetting for fractional ylabels in LinePlot Nov 1, 2021
@neutrinoceros neutrinoceros marked this pull request as ready for review November 1, 2021 10:00
@neutrinoceros neutrinoceros mentioned this pull request Nov 1, 2021
42 tasks
matthewturk
matthewturk previously approved these changes Nov 1, 2021
cphyc
cphyc previously approved these changes Nov 1, 2021
Copy link
Member

@cphyc cphyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy about the changes if the answers are bumped!

@neutrinoceros
Copy link
Member Author

done in yt-project/answer-store#26

@neutrinoceros
Copy link
Member Author

@matthewturk, @cphyc, any chance you could merge the answer store PR ?

@matthewturk
Copy link
Member

merged

@matthewturk matthewturk merged commit 60c3524 into yt-project:main Nov 1, 2021
@neutrinoceros neutrinoceros deleted the fix_ylabel_frac branch November 1, 2021 21:18
@neutrinoceros
Copy link
Member Author

@meeseeksdev backport to yt-4.0.x

@lumberbot-app
Copy link

lumberbot-app bot commented Nov 6, 2021

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout yt-4.0.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 60c352456148c62a407a376673092e33d9db03e3
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #3637: BUG: fix LaTeX typesetting for fractional ylabels in LinePlot'
  1. Push to a named branch :
git push YOURFORK yt-4.0.x:auto-backport-of-pr-3637-on-yt-4.0.x
  1. Create a PR against branch yt-4.0.x, I would have named this PR:

"Backport PR #3637 on branch yt-4.0.x (BUG: fix LaTeX typesetting for fractional ylabels in LinePlot)"

And apply the correct labels and milestones.

Congratulation you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove Still Needs Manual Backport label once the PR gets merged.

If these instruction are inaccurate, feel free to suggest an improvement.

@neutrinoceros
Copy link
Member Author

the conflict for this one is in the answer-store submodule. Most likely we need to merge #3644 first and then we'll be able to backport this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: incorrect LaTeX typesetting in ylabel for fractions
3 participants