-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: fix plot bounds for slices in cylindrical coordinates #3820
Conversation
c740346
to
b057781
Compare
ed11c31
to
06383a5
Compare
Also addressed my second comment in the original issue |
d333722
to
3a00801
Compare
3a00801
to
6be4799
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good fix to an annoying problem! Thanks, @neutrinoceros
@matthewturk any reason not to merge this yet ? |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
BUG: fix plot bounds for slices in cylindrical coordinates
Manual backport #3820 to yt-4.0.x (BUG: fix plot bounds for slices in cylindrical coordinates)
PR Summary
Reutilizing some bits from #3533, fix #3819
Opening as a draft because there's a secondary problem to solve. Namely, axes ticks are incorrect (0, 0) should always be the origin, not the display center