Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unneeded logs using private API #3847

Merged
merged 1 commit into from
Mar 18, 2022
Merged

remove unneeded logs using private API #3847

merged 1 commit into from
Mar 18, 2022

Conversation

zingale
Copy link
Member

@zingale zingale commented Mar 14, 2022 •
edited
Loading

PR Summary

this closes #3845

PR Checklist

  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

@zingale zingale added the docs label Mar 14, 2022
neutrinoceros
neutrinoceros approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! FTR I agree with you that we should show how to do this using only the public API, or actually implement a way to do it if there isn't.

@neutrinoceros neutrinoceros added this to the 4.1.0 milestone Mar 14, 2022
@neutrinoceros
Copy link
Member

Ah, this is stuck because auto-merge is waiting for a job that will not be triggered for a pure docs patch. I think only an owner can merge this. Ping @matthewturk

@matthewturk matthewturk merged commit 0d84602 into yt-project:main Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neutrinoceros neutrinoceros neutrinoceros approved these changes

Assignees
No one assigned
Labels
bug docs
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

DOC: private methods used in cookbook recipe
3 participants
@zingale @neutrinoceros @matthewturk