Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: don't install nose on python >= 3.10 #4344

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

neutrinoceros
Copy link
Member

PR Summary

Trying to get rid of nose as a test dependency in environments where it's already unusable. This is a necessary first step for testing with Python 3.12, which should become possible later this year.
As a side effect, expose many test modules that depends on it still.

@neutrinoceros neutrinoceros added the tests: running tests Issues with the test setup label Feb 19, 2023
@neutrinoceros neutrinoceros added enhancement Making something better dependencies Pull requests that update a dependency file labels Feb 19, 2023
@neutrinoceros
Copy link
Member Author

The one failure is real, but could be filtered (deprecation warning from setuptools via glue)

@neutrinoceros neutrinoceros marked this pull request as ready for review February 19, 2023 21:51
@neutrinoceros neutrinoceros linked an issue Mar 6, 2023 that may be closed by this pull request
@neutrinoceros
Copy link
Member Author

This now fully resolves #4366, including future proofing for when Python 3.8 and 3.9 patch releases ship with setuptools>=67.5

@Xarthisius Xarthisius merged commit 5256875 into yt-project:main Mar 10, 2023
@neutrinoceros neutrinoceros deleted the py312_testability branch March 10, 2023 07:36
@neutrinoceros neutrinoceros mentioned this pull request Mar 13, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement Making something better tests: running tests Issues with the test setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: pkg_resources is now fully deprecated
2 participants