Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: explicitly specify build-backend #4583

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Jul 19, 2023

I'm setting the implicit value build-backend explicitly, as recommended.
setuptools' doc also clarifies that wheel requirement isn't needed as it's implied by using the setuptools_meta backend, so I'm removing it. See https://setuptools.pypa.io/en/latest/userguide/quickstart.html#basic-use

You should only include wheel in requires if you need to explicitly access it during build time (e.g. if your project needs a setup.py script that imports wheel).

@neutrinoceros neutrinoceros added enhancement Making something better infrastructure Related to CI, versioning, websites, organizational issues, etc labels Jul 19, 2023
@neutrinoceros neutrinoceros marked this pull request as draft July 19, 2023 16:01
@neutrinoceros neutrinoceros changed the title BLD: explicitly specify build-backend (setuptools.build_meta) BLD: explicitly specify build-backend Jul 19, 2023
@neutrinoceros neutrinoceros marked this pull request as ready for review July 19, 2023 17:28
@neutrinoceros neutrinoceros added build related to the build process and removed infrastructure Related to CI, versioning, websites, organizational issues, etc labels Jul 31, 2023
@Xarthisius Xarthisius merged commit 9539524 into yt-project:main Aug 7, 2023
9 checks passed
@neutrinoceros neutrinoceros deleted the drop_wheel_req branch August 7, 2023 17:07
@neutrinoceros neutrinoceros added this to the 4.3.0 milestone Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build related to the build process enhancement Making something better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants