-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix order of Athena++ cylindrical coords #4801
Fix order of Athena++ cylindrical coords #4801
Conversation
Hi! Welcome, and thanks for opening this pull request. We have some guidelines for new pull requests, and soon you'll hear back about the results of our tests and continuous integration checks. Thank you for your contribution! |
Currently this PR changes to coordinate order for Athena++ cylindrical datasets and also fixes it for Cartesian and spherical polar dataset. I need to update it to work for GR coordinates. Final version will leave everything untouched except for cylindrical |
Co-authored-by: Clément Robert <cr52@protonmail.com>
I think this is ready to merge. assuming the CI is working+ passing and there are no other changes. |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
@yt-fido test this please |
lgtm! |
Hooray! Congratulations on your first merged pull request! We hope we keep seeing you around! 🎆 |
@meeseeksdev backport to yt-4.3.x |
@matthewturk please remember to milestone bug fix PRs before merging. Thank you ! |
PR Summary
Changes the ordering of coordinates for Athena++ cylindrical datasets to$(r,\theta,z)$ within the Athena++ frontend.
Addresses #4796
PR Checklist