BLD: fix segfault with manylinux2014 #4911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yut23
added
infrastructure
|
Thanks a lot for digging into this ! I merged #4909. Can you rebase this to simplify the diff ? |
The cibuildwheel docs say that manylinux2014 supports all C++ standards up to C++17 (https://cibuildwheel.pypa.io/en/stable/cpp_standards/). Fixes: yt-project#4910
yut23
force-pushed
the
build/fix_linux_wheel_build
branch
from
295cabe
to
2068504
Compare
neutrinoceros
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Follow-up to #4909.
We originally had static linking enabled due to ABI conflicts, as discussed in #3406. However, the cibuildwheel docs currently say that manylinux2014 supports all C++ standards up to C++17 (https://cibuildwheel.pypa.io/en/stable/cpp_standards/).
I think the segfaults may have to do with multiple versions of libstdc++ being loaded at the same time. A couple of compiled modules in matplotlib dynamically link to
libstdc++.so.6, which seems like it could cause this sort of issue.